Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(austinp): link libbfd statically #134

Merged
merged 1 commit into from
Oct 20, 2022
Merged

ci(austinp): link libbfd statically #134

merged 1 commit into from
Oct 20, 2022

Conversation

P403n1x87
Copy link
Owner

Requirements for Adding, Changing, Fixing or Removing a Feature

Fill out the template below. Any pull request that does not include enough
information to be reviewed in a timely manner may be closed at the maintainers'
discretion.

Description of the Change

Alternate Designs

Regressions

Verification Process

@P403n1x87 P403n1x87 added this to the Austin 3.4 milestone Oct 15, 2022
@P403n1x87 P403n1x87 self-assigned this Oct 15, 2022
@P403n1x87 P403n1x87 force-pushed the release/bfd-static-linking branch from 8bee32b to 17f5ee4 Compare October 15, 2022 17:47
@codecov
Copy link

codecov bot commented Oct 15, 2022 •
edited
Loading

Codecov Report

Base: 69.59% // Head: 69.59% // No change to project coverage 👍

Coverage data is based on head (d0896a4) compared to base (d0896a4).
Patch has no changes to coverable lines.

❗ Current head d0896a4 differs from pull request most recent head a4c7207. Consider uploading reports for the commit a4c7207 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##            devel     #134   +/-   ##
=======================================
  Coverage   69.59%   69.59%           
=======================================
  Files          23       23           
  Lines        2394     2394           
  Branches      697      697           
=======================================
  Hits         1666     1666           
  Misses        406      406           
  Partials      322      322

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@P403n1x87 P403n1x87 force-pushed the release/bfd-static-linking branch from 17f5ee4 to 6f2e982 Compare October 15, 2022 17:59
@P403n1x87
Copy link
Owner Author

Compilation fails on 20.04 runners but works on a local 22.04 installation.

@P403n1x87 P403n1x87 force-pushed the release/bfd-static-linking branch from 6f2e982 to a4c7207 Compare October 20, 2022 11:19
@P403n1x87
Copy link
Owner Author

Compilation fails on 20.04 runners but works on a local 22.04 installation.

Resolved by ensuring that -ldl is added at the very end.

@P403n1x87 P403n1x87 marked this pull request as ready for review October 20, 2022 11:24
@P403n1x87 P403n1x87 merged commit 74efe06 into devel Oct 20, 2022
@P403n1x87 P403n1x87 deleted the release/bfd-static-linking branch October 20, 2022 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@P403n1x87 P403n1x87

Labels
None yet
Projects
None yet
Milestone
Austin 3.4
Development

Successfully merging this pull request may close these issues.
1 participant
@P403n1x87